Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require sockjs_client_wrapper ^1.0.3 #304

Merged
merged 1 commit into from
Apr 20, 2018

Conversation

evanweible-wf
Copy link
Contributor

Description

Update pubspec to require sockjs_client_wrapper ^1.0.3 because:

  • 1.0.2 fixed overly verbose logging
  • 1.0.3 introduced compatibility with DDC & Dart 2

This will ensure that consumers who require the latest w_transport will also get the these fixes without having to depend directly on sockjs_client_wrapper.

Testing

  • CI passes

Code Review

@Workiva/app-frameworks

- 1.0.2 fixed overly verbose logging
- 1.0.3 introduced compatibility with DDC & Dart 2
@evanweible-wf evanweible-wf requested a review from a team as a code owner April 20, 2018 16:53
@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on HipChat: InfoSec Forum.

@codecov-io
Copy link

Codecov Report

Merging #304 into master will not change coverage.
The diff coverage is n/a.

@jayudey-wf
Copy link
Contributor

jayudey-wf commented Apr 20, 2018

QA +1

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • passing CI
  • Security review (if required)
  • Unit tests created/updated (n/a dep update)
  • All unit tests pass

Merging into master.

@jayudey-wf
Copy link
Contributor

@Workiva/release-management-pp

@rmconsole-wf rmconsole-wf merged commit 62cdff6 into master Apr 20, 2018
@rmconsole6-wk rmconsole6-wk deleted the update_minimum_sockjs_client_wrapper branch April 20, 2018 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants