WP-6212 Update HttpRequestTypes.md #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@evanweible-wf - Another relative --> explicit url update. Please review. |
Module FindingsNo security relevant content detected. Please review for security relevance and request security review as needed. |
| @@ -1,6 +1,6 @@ | |||
| ## HTTP: Request Types | |||
|
|
|||
| The [basic guide to sending requests](/docs/guides/HttpSendRequestReceiveResponseHandleFailure.md) | |||
| The [basic guide to sending requests](https://github.com/Workiva/w_transport/blob/master/docs/guides/HttpSendRequestReceiveResponseHandleFailure.md) | |||
There was a problem hiding this comment.
I'm okay with this because I don't see these guides changing any time soon, but this is another unfortunate limitation of having to use absolute URLs: by pointing to master, we will break historical linking. Let's say we release a v4 in the future but someone wants to browse the repo at the latest v3 revision - these links would be broken because they don't allow the user's current context to be taken into account.
evanweible-wf
approved these changes
Mar 9, 2018
|
+10
QA +1 |
rmconsole3-wf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: relative path results in broken link.
Solution: updated path to explicit
Testing: Passing Smithy