WP-5850 Use hasProperty to detect sockjs.js #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmconsole2-wf
changed the title
RavenNumber of Findings: 0MagpieNumber of findings: 0 |
maxwellpeterson-wf
approved these changes
Jan 29, 2018
jayudey-wf
reviewed
Jan 29, 2018
| @@ -67,6 +74,8 @@ <h1>Echo</h1> | |||
| <pre id="logs"></pre> | |||
| </div> | |||
|
|
|||
| <!--<script src="packages/sockjs_client_wrapper/sockjs.js"></script>--> | |||
There was a problem hiding this comment.
should these be committed as being commented out?
There was a problem hiding this comment.
Yeah I don't have a great way to dynamically add/remove the script via the example UI, so I figured this was a good middle ground for now.
evanweible-wf
force-pushed
the
fix_sockjs_detection
branch
from
519c893 to
f11698a
Compare
maxwellpeterson-wf
approved these changes
Jan 29, 2018
|
QA +1
Merging into master. |
|
@Workiva/release-management-pp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Actually accessing the
SockJSobject onjs.contextthrows because it ends up trying to call the object.Solution
The proper way to check is to use
js.context.hasPropertywhich will simply check to see if theSockJSobject is available, which is all we're after.Code Review
@Workiva/app-frameworks