Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP-5472 Add dependency_validator CI check #293

Merged
merged 1 commit into from
Nov 20, 2017

Conversation

evanweible-wf
Copy link
Contributor

Changes

Adds dependency_validator as a dev dep and runs its check during CI.

Testing

  • CI passes

Code Review

@Workiva/web-platform-pp @jacehensley-wf

@aviary-wf
Copy link

Raven

Number of Findings: 0

@evanweible-wf evanweible-wf changed the title Add dependency_validator CI check WP-5472 Add dependency_validator CI check Nov 17, 2017
@codecov-io
Copy link

codecov-io commented Nov 17, 2017

Codecov Report

Merging #293 into master will not change coverage.
The diff coverage is n/a.

@evanweible-wf
Copy link
Contributor Author

@Workiva/web-platform-pp ready for merge

@sebastianmalysa-wf
Copy link

QA +1

  • Testing instruction
  • Dev +1's
  • Dev/QA +10
    - CI passes
  • All unit tests pass

@Workiva/release-management-pp

@rmconsole-wf rmconsole-wf merged commit ba92d82 into master Nov 20, 2017
@rm-astro-wf rm-astro-wf deleted the add_dependency_validator branch November 20, 2017 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants