Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WP-5326 Remove unused dependencies. #292

Merged
merged 1 commit into from
Oct 25, 2017
Merged

WP-5326 Remove unused dependencies. #292

merged 1 commit into from
Oct 25, 2017

Conversation

evanweible-wf
Copy link
Contributor

@evanweible-wf evanweible-wf commented Oct 11, 2017 •
edited
Loading

Issue

There were two dev_dependencies that were unused.

Solution

Remove them.

Testing

  • CI passes

Code Review

@Workiva/web-platform-pp

@rmconsole2-wf rmconsole2-wf changed the title Remove unused dependencies. WP-5326 Remove unused dependencies. Oct 11, 2017
@aviary2-wf
Copy link

aviary2-wf commented Oct 11, 2017 •
edited
Loading

Raven

Number of Findings: 0

@codecov-io
Copy link

codecov-io commented Oct 11, 2017 •
edited
Loading

Codecov Report

Merging #292 into master will not change coverage.
The diff coverage is n/a.

@evanweible-wf evanweible-wf force-pushed the remove_unused_dependencies branch from fc61114 to 4229204 Compare October 11, 2017 23:29
@evanweible-wf
Copy link
Contributor Author

@Workiva/web-platform-pp ready for merge

@maxwellpeterson-wf
Copy link
Member

QA +1

  • Minimum dependency bump only
  • Dev +1's
  • CI passes
  • Dependency scan clean

@Workiva/release-management-pp

@rmconsole-wf
Copy link
Contributor

+1 from RM

@rmconsole-wf rmconsole-wf merged commit 14cc250 into master Oct 25, 2017
@rmconsole2-wf rmconsole2-wf deleted the remove_unused_dependencies branch October 25, 2017 17:23
@rmconsole-readonly-wk rmconsole-readonly-wk mentioned this pull request Jan 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxwellpeterson-wf maxwellpeterson-wf maxwellpeterson-wf approved these changes

@sebastianmalysa-wf sebastianmalysa-wf sebastianmalysa-wf approved these changes

Assignees
No one assigned
Labels
RM Ready type: Dependency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@evanweible-wf @aviary2-wf @codecov-io @maxwellpeterson-wf @rmconsole-wf @sebastianmalysa-wf