Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP-4759 Add explicit dependency on meta #284

Merged
merged 1 commit into from
Jul 20, 2017
Merged

Conversation

evanweible-wf
Copy link
Contributor

Issue

pub publish --dry-run shows this warning:

* line 17, column 1 of lib/src/web_socket/global_web_socket_monitor.dart: This package doesn't depend on meta.
  import 'package:meta/meta.dart' show required;
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Solution

Add explicit dependency on the meta package.

Testing

  • CI passes
  • pub publish --dry-run does not show the meta package warning

Code Review

@Workiva/web-platform-pp

@aviary-wf
Copy link

Raven

Number of Findings: 0

@codecov-io
Copy link

codecov-io commented Jul 19, 2017

Codecov Report

Merging #284 into master will not change coverage.
The diff coverage is n/a.

@rmconsole2-wf rmconsole2-wf changed the title Add explicit dependency on meta WP-4759 Add explicit dependency on meta Jul 19, 2017
@jayudey-wf
Copy link
Contributor

+10

  • verified that running pub publish --dry-run produced no warnings related to the meta package

@maxwellpeterson-wf
Copy link
Member

QA +1

  • Dependency update only
  • Dev +1's
  • CI passes
  • Dependency scan clean

@Workiva/release-management-pp

@rmconsole-wf
Copy link
Contributor

+1 from RM

@rmconsole-wf rmconsole-wf merged commit 24ba86d into master Jul 20, 2017
@rm-astro-wf rm-astro-wf deleted the explicit_meta_dep branch July 20, 2017 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants