Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEDX-126 FED-1719 Null Safety Migration #63
FEDX-126 FED-1719 Null Safety Migration #63
Changes from all commits
65d968a
be7cb23
afaea6e
e6794d3
a6f489a
1fb1844
ffb26fb
afa5c15
7f7850c
a7a7689
c22e82f
844e7b7
62adb47
083aa73
ebbcabc
fab1044
976b962
8f45e91
25f3e5c
e552d85
417a754
e7426ca
7b76f36
fb14bc2
afbcab2
a02b547
951a135
9566232
fecb0b1
07a008f
42410ab
17a41cf
6bc0767
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a bunch of other unrelated type signatures - a param for
Element container
is nullable. Any reason why this is different?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's because it's non-nullable in TS. A lot of
container
related arguments are nullable because the defaultscreen.container
is set todocument.body
which is nullable. I talked to Greg about it though and he said it's safe to just enforce thatdocument.body
is non-null by the time it's used so then I can make allcontainer
args non-nullable instead so I'll update thoseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though now looking at that TS type, I'm not sure why
message
is typed asObject?
instead ofString?
- do you happen to remember?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea, honestly