CPLAT-13506 Add user-events JS Interop #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ As a sort of “test” that the matchers are public.
+ To have a consistent, familiar API for Dart users
aaronlademann-wf
previously requested changes
May 12, 2021
sydneyjodon-wk
dismissed
aaronlademann-wf’s stale review
Feedback addressed in 115df5e
greglittlefield-wf
previously requested changes
May 13, 2021
sydneyjodon-wk
dismissed
greglittlefield-wf’s stale review
Feedback addressed in 875435c
|
@greglittlefield-wf your review was submitted after a new commit (0b71921) was pushed, but is being applied to 875435c. Please review the latest commit and resubmit your approval. |
greglittlefield-wf
approved these changes
May 14, 2021
|
@Workiva/release-management-pp |
rmconsole-wf
added
Merge Requirements Met
RM Ready
and removed
Merge Requirements Unmet
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wraps all the
userEventutilities and exposes them viaUserEvent:UserEvent.clickUserEvent.dblClickUserEvent.typeUserEvent.typeWithDelay(needs to be a separate method to return aFuture)UserEvent.keyboardUserEvent.keyboardWithDelay(needs to be a separate method to return aFuture)UserEvent.uploadUserEvent.clearUserEvent.selectOptionsUserEvent.deselectOptionsUserEvent.tabUserEvent.hoverUserEvent.unhoverUserEvent.pasteQA Instructions
dhttpd <path to dartdoc directory>and verify the docs look as expected.