Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FED-1246 Add environment to deploy docs action #59

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

hunterbreathat-wk
Copy link
Contributor

Motivation

The deploy stage is failing due to missing an environment. Let's add that. Similar to this example

Changes

  • Add environment to deploy docs workflow

Release Notes

  • Add environment to deploy docs workflow

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Frameworks Design member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@hunterbreathat-wk hunterbreathat-wk temporarily deployed to github-pages April 17, 2023 13:40 — with GitHub Actions Inactive
@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@hunterbreathat-wk hunterbreathat-wk requested review from a team and sydneyjodon-wk and removed request for a team April 17, 2023 16:31
Copy link
Contributor

@sydneyjodon-wk sydneyjodon-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

@hunterbreathat-wk
Copy link
Contributor Author

@Workiva/release-management-p

@hunterbreathat-wk
Copy link
Contributor Author

Rosie

@rmconsole6-wk rmconsole6-wk changed the title Add environment to deploy docs action FED-1246 Add environment to deploy docs action Apr 17, 2023
@hunterbreathat-wk
Copy link
Contributor Author

Semver

@hunterbreathat-wk
Copy link
Contributor Author

Applying semver patch as there is no functional change to the actual library

@hunterbreathat-wk
Copy link
Contributor Author

Rosie

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole7-wk rmconsole7-wk merged commit 07f0c68 into master Apr 17, 2023
@rmconsole7-wk rmconsole7-wk deleted the add-gh-pages-environment branch April 17, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants