Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix key and condition #58

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Fix key and condition #58

merged 2 commits into from
Apr 13, 2023

Conversation

hunterbreathat-wk
Copy link
Contributor

@hunterbreathat-wk hunterbreathat-wk commented Apr 13, 2023

Motivation

A check wasn't updated after the change of step ordering, and a key was wrong.

Changes

  • Update incorrect key name
  • Update check

Release Notes

  • Update incorrect key name
  • Update check

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Frameworks Design member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@hunterbreathat-wk hunterbreathat-wk requested review from a team and annawatson-wk and removed request for a team April 13, 2023 16:35
Copy link
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA +1

🤞

@Workiva/release-management-pp

@aaronlademann-wf
Copy link
Contributor

Semver +1

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole5-wk rmconsole5-wk merged commit 72c3035 into master Apr 13, 2023
@rmconsole5-wk rmconsole5-wk deleted the fix-archive-step branch April 13, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants