Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FED-1155: Migrate to GH deploy pages action #57

Merged
merged 15 commits into from
Apr 13, 2023
Merged

FED-1155: Migrate to GH deploy pages action #57

merged 15 commits into from
Apr 13, 2023

Conversation

hunterbreathat-wk
Copy link
Contributor

@hunterbreathat-wk hunterbreathat-wk commented Mar 13, 2023

Motivation

Currently we use an action from an individual unverified developer to deploy our GIthub pages, let's migrate to a verified set of actions to reduce risk.

Changes

  • Update Github workflow to verified actions
  • Migrate to dart 2.18.4 to get CI passing

Release Notes

  • Update build and deploy docs workflow
  • Migrate to dart 2.18.4

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Frameworks Design member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@hunterbreathat-wk hunterbreathat-wk requested review from a team and annawatson-wk and removed request for a team March 20, 2023 19:53
annawatson-wk
annawatson-wk previously approved these changes Mar 20, 2023
@aaronlademann-wf
Copy link
Contributor

@hunterbreathat-wk can you think of a way to validate that the deploy is working without merging this PR?

pubspec.yaml Outdated Show resolved Hide resolved
.github/workflows/dart_ci.yml Show resolved Hide resolved
Copy link
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA +1

@Workiva/release-management-pp

@aaronlademann-wf aaronlademann-wf dismissed greglittlefield-wf’s stale review April 13, 2023 16:13

He said I could QA it :)

@aaronlademann-wf
Copy link
Contributor

Semver +1

@Workiva/release-management-pp

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole3-wf rmconsole3-wf merged commit 2d46abd into master Apr 13, 2023
@rmconsole3-wf rmconsole3-wf deleted the fed-1155 branch April 13, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants