Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the skipPointerEventsCheck check #48

Merged
merged 7 commits into from
Apr 18, 2022

Conversation

joebingham-wk
Copy link
Contributor

@joebingham-wk joebingham-wk commented Apr 14, 2022

Motivation

Since we've last generated our js src and wrapped the APIs, the parameter skipPointerEventsCheck has been exposed on UserEvent clicking APIs. Using it isn't a super rare use case, so this PR exposes the parameter to give consumers access.

Changes

  • Consume the last minor version of user-event v13 (v14 was just released two weeks ago)
  • Add the skipPointerEventsCheck option to click and dblClick
  • Add tests

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed
    • Steps from PR author:
      • CI passes and tests correctly exercise the parameter
    • Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@joebingham-wk joebingham-wk requested a review from a team April 14, 2022 18:52
Copy link
Contributor

@sydneyjodon-wk sydneyjodon-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This option will be really nice!

lib/src/user_event/user_event.dart Show resolved Hide resolved
test/unit/user_event/click_test.dart Outdated Show resolved Hide resolved
lib/src/user_event/user_event.dart Outdated Show resolved Hide resolved
@joebingham-wk
Copy link
Contributor Author

Good catches, @sydneyjodon-wk! All feedback addressed!

Copy link
Contributor

@sydneyjodon-wk sydneyjodon-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole4-wk rmconsole4-wk merged commit 480df14 into master Apr 18, 2022
@rmconsole4-wk rmconsole4-wk deleted the expose-skip-pointer-event-option branch April 18, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants