Fix test ID queries not properly escaping RegExps #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
| final testIdMatcher = exact ? RegExp('(\\s|^)$testId(\\s|\$)') : RegExp('(.?)$testId(.?)', caseSensitive: false); | ||
| final testIdMatcher = exact | ||
| ? RegExp('(\\s|^)${RegExp.escape(testId as String)}(\\s|\$)') | ||
| : RegExp('(.?)${RegExp.escape(testId as String)}(.?)', caseSensitive: false); |
There was a problem hiding this comment.
These as Strings are needed to fix implicit cast errors, since testId hasn't been promoted to String here like you'd expect it to (which I believe is fixed in null safety)
kevinfox-wk
previously approved these changes
Dec 10, 2021
greglittlefield-wf
dismissed stale reviews from aaronlademann-wf and kevinfox-wk
via
d3c235a
|
QA +1
|
|
@Workiva/release-management-pp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Our logic that converts test IDs to RegExps for querying doesn't escape the test IDs properly, meaning any regular expression syntax in test IDs will cause unexpected behavior (including false negatives, false positives, and runtime errors, based on the input).
Changes
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: