Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration Guides Wording Tweaks #21

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

sydneyjodon-wk
Copy link
Contributor

@sydneyjodon-wk sydneyjodon-wk commented Jul 8, 2021

Motivation

Based on Trent's feedback thread.

Changes

  • Soften some of the wording around OverReact examples
  • Add note about querying for roles encouraging accessibility
  • Update rendering example

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@rmconsole-wf
Copy link

rmconsole-wf commented Jul 8, 2021

Merge Requirements Met ✅

Request Rosie to automerge this pull request by including @Workiva/release-management-p in a comment.

General Information

Ticket(s): None found in title
Code Review(s): #21
Release Image Tags:

Reviewers: joebingham-wk, trentgrover-wf, sydneyjodon-wk

Additional Information

Watchlist Notifications: None

	When this pull is merged I will add it to the following release:
	Current version: react_testing_library 1.1.1
	Version after merge: react_testing_library 1.1.1
	Release Ticket(s): RM-107651

	This pull is considered a release pull
	The options defined for this repo will be carried out


Note: This is a shortened report. Click here to view Rosie's full evaluation.
Last updated on Friday, July 09 04:35 PM CST

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@semveraudit-wf
Copy link

Public API Changes

No changes to the public API found for commit 76cbf95

Showing results for 76cbf95

Powered by semver-audit-service. Please report any problems by filing an issue.
Reported by the dart semver audit client 2.2.1
Browse public API.

@sydneyjodon-wk sydneyjodon-wk changed the title Migration Guide Wording Tweaks Migration Guides Wording Tweaks Jul 8, 2021
@sydneyjodon-wk sydneyjodon-wk marked this pull request as ready for review July 8, 2021 22:40
Copy link

@trentgrover-wf trentgrover-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! - thx

Copy link
Contributor

@joebingham-wk joebingham-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10!

  • CI passes
  • Verify the formatting still looks fine on the two updated

@sydneyjodon-wk
Copy link
Contributor Author

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole5-wk rmconsole5-wk merged commit ec4afc7 into master Jul 9, 2021
@rmconsole5-wk rmconsole5-wk deleted the migration-guide-wording-tweaks branch July 9, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants