[INTRISK-83943] default isEvalSupported to false #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanelliott-wk
changed the title
ryanelliott-wk
requested review from
abigailbeets-wk and
pauldanner-wk
as code owners
ryanelliott-wk
commented
Jan 8, 2025
pauldanner-wk
approved these changes
Jan 8, 2025
|
No CSP warning with the latest build of the markup_client consumer! https://staging.wdesk.org/fews/v1/serve/cdn-dev:markup_client@6903762/a/QWNjb3VudB8xMTQ2ODUyNDY2/markup/eyJhdHRhY2htZW50X2lkIjoxMDIyMjMwLCJwcm9kdWNlcl93dXJsIjoid3VybDovL3NoZWV0cy52MC8wOnNoZWV0c182Y2ViYmQ0YjYwMzI0YzhiYmMzMGFkMzRlZjZjMGYyOCIsInRpbWVzdGFtcCI6IiJ9 |
|
@Workiva/release-management-p |
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a vulnerability in the version of PDFjs used by markup_client, and the graph/grc markup viewers. It has been addressed in a recent version of PDFjs but upgrading is not trivial. Fortunately there is a workaround. Disabling eval support prevents the attack vector.
See the ticket for repro details.
Here is a consumer for testing the fix: https://github.com/Workiva/markup_client/pull/4798