FED-2442 Merge version 3.0.0 changes to master #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Null safety migration
FED-2223 query(All)ByTestId null arg improvements
FED-2285 Skip testing late nullable props in common component test utils
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
greglittlefield-wf
previously approved these changes
Mar 25, 2024
| * The first argument of `queryByTestId` / `queryAllByTestId` (`root`) is now non-nullable ([#157](https://github.com/Workiva/over_react_test/pull/157)). | ||
| * SDK / Dependency Versioning: | ||
| * Increase minimum Dart SDK version from `2.11.0` to `2.13.0`. | ||
| * Increase minimum `react` version from `6.0.1` to `7.0.0`. |
There was a problem hiding this comment.
#nit This will also have over_react ^5.0.0 once it's released, so we could also add that now
There was a problem hiding this comment.
I'll make a note to add that in the actual release PR
FED-2451 Make root args to query(All)ByTestId nullable
sydneyjodon-wk
approved these changes
Mar 26, 2024
|
RM +1 |
|
@Workiva/release-management-pp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first step to releasing version 3.0.0 of this library, we need to:
v3_wipbranch into master without actually tagging it as a release.Then, once
over_reactversion 5 has been released, we can consume it and release version 3 of this library while bumping the minimumover_reactversion at the same time.