Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused variable #206

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

yuzurihaaa
Copy link
Contributor

@yuzurihaaa yuzurihaaa commented Jan 15, 2025

Which problem is this PR solving?

  1. CI fails on my PR feat: logs api #203
  2. Suspect CI failed due to warning output when running make analyze

Short description of the change

  1. Remove unused variable.

How Has This Been Tested?

  1. CI status

@yuzurihaaa yuzurihaaa mentioned this pull request Jan 15, 2025
2 tasks
@yuzurihaaa yuzurihaaa changed the title chore: remove unused variable. Suspect CI failed due to warning. chore: remove unused variable Jan 15, 2025
@blakeroberts-wk
Copy link
Contributor

QA +1 ci is sufficient

@blakeroberts-wk
Copy link
Contributor

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@yuzurihaaa
Copy link
Contributor Author

Can I know what is Rosie check?

@btr-rmconsole-4 btr-rmconsole-4 bot merged commit ddc57d6 into Workiva:master Jan 15, 2025
3 checks passed
@yuzurihaaa
Copy link
Contributor Author

Welp, suddenly it works 🤷

@yuzurihaaa yuzurihaaa deleted the chore/yr/fix-analyze branch January 15, 2025 16:34
@blakeroberts-wk
Copy link
Contributor

Rosie is an internal bot that helps make sure we've crossed our t's, dotted our i's, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants