Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make registerGlobalContextManager public API #183

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

jonathancampbell-wk
Copy link
Contributor

Which problem is this PR solving?

dart analyze throws a warning when importing experimental libraries due to this linting rule. This PR moves an experimental API into the public API so that it can be consumed by a production app.

Checklist:

  • Unit tests have been added
  • Documentation has been updated

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@jonathancampbell-wk jonathancampbell-wk force-pushed the jcampbell/remove_experimental_api branch from 91cea6e to 95e3c97 Compare August 15, 2024 14:20
@jonathancampbell-wk jonathancampbell-wk force-pushed the jcampbell/remove_experimental_api branch from 95e3c97 to 3b92994 Compare August 15, 2024 14:21
@jonathancampbell-wk
Copy link
Contributor Author

@Workiva/release-management-p

@jonathancampbell-wk
Copy link
Contributor Author

QA +1 CI is sufficient.

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole4-wk rmconsole4-wk merged commit 2d38bc3 into master Aug 15, 2024
4 checks passed
@rmconsole4-wk rmconsole4-wk deleted the jcampbell/remove_experimental_api branch August 15, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants