-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
export ValidationResults #192
export ValidationResults #192
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@mx1up Thanks for adding this! Would you do us a favor and revert |
This reverts commit 112ba7e.
sure, i reverted the commit bumping the version, which also reverts the changelog as I guess it's also no longer in use.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@mx1up Now format is failing 😔 Would you mind fixing? Thank you! Once that's done (and barring no other problems), we'll get this merged for you. |
@mx1up Come to think of it, I have no idea why format is failing 🤔 It's the same as it was before you reverted the version bump. I also pulled down your branch and ran format on it, and it came back clean. So I'm confused why it's failing in CI. Let me see if it's our CI at fault. |
@joecotton-wk were those checks run on the last 2 PRs? I don't see them in the PR activity log. My guess is:
that could explain it.. |
either way, it needs to be fixed , so I updated the fork with latest master and reformatted the file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@Workiva/release-management-p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Ultimate problem:
ValidationResults
can not be used outside packageHow it was fixed:
export the class
fixes #175