Remove gorilla/context #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
bradwest-wk
force-pushed
the
remove-gorilla-context
branch
2 times, most recently
from
22fdcca to
1abdb25
Compare
bradwest-wk
force-pushed
the
remove-gorilla-context
branch
2 times, most recently
from
51f1577 to
cb8fedc
Compare
tomdeering-wf
previously approved these changes
Nov 13, 2020
trentonsmith-wf
previously approved these changes
Nov 16, 2020
bradwest-wk
force-pushed
the
remove-gorilla-context
branch
from
3bde698 to
4ca0815
Compare
blakeroberts-wk
previously approved these changes
Nov 17, 2020
|
security +1
|
|
security +1 |
trentonsmith-wf
previously approved these changes
Nov 18, 2020
blakeroberts-wk
previously approved these changes
Nov 19, 2020
https://golang.org/ref/mod#major-version-suffixes Major version suffixes are not allowed at major versions v0 or v1. There is no need to change the module path between v0 and v1 because v0 versions are unstable and have no compatibility guarantee. Additionally, for most modules, v1 is backwards compatible with the last v0 version; a v1 version acts as a commitment to compatibility, rather than an indication of incompatible changes compared with v0.
bradwest-wk
dismissed stale reviews from blakeroberts-wk and trentonsmith-wf
via
b86cc45
|
QA +1 Pushed to test branch and tested against the analytics_gateway. No issues handling contextual information. |
|
@trentonsmith-wf @blakemorris-wk I apologize for all the false starts here. I misunderstood the limitations of major version suffixes and (earlier) stupidly assumed this lib was at a stable release. Should be good to go now. |
blakeroberts-wk
approved these changes
Nov 20, 2020
|
QA +1 refresh @Workiva/release-management |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to remove dependence on
gorilla/context, which is deprecated. Usages are replaced with the stdlibcontextpackage, specifically with calls tonet/http'sRequest.Context()andcontext.WithValue().In addition to this update, I've updated to go 1.15 and go modules and version bumped to v2. The commit history should be straight forward. In particular, 4ca0815 shows the changes I made to v1.
Test
The interface remained the same. Consumers of go-rest should not use
gorilla/context. Should be tested against services using this library (analytics_gateway).