Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RM-16227 Add path trimming middleware with unit tests #77

Merged
merged 2 commits into from
Oct 2, 2017
Merged

RM-16227 Add path trimming middleware with unit tests #77

merged 2 commits into from
Oct 2, 2017

Conversation

chriskempf-wf
Copy link
Contributor

This adds a middleware that will trim the provided prefix from request paths.

For example initialized with a trim of '/foo' the path '/foo/bar' will be trimmed to '/bar'

@brianshannan-wf @stevenosborne-wf

@aviary-wf
Copy link

Raven

Number of Findings: 0

@rm-astro-wf rm-astro-wf changed the title Add path trimming middleware with unit tests RM-16227 Add path trimming middleware with unit tests Sep 25, 2017
@robertsheehy-wf
Copy link

+1

@anthonypagnotta-wf
Copy link

+1

@stevenosborne-wf
Copy link

lgtm

@colefeisthamel-wf
Copy link
Contributor

+1 merging

@colefeisthamel-wf colefeisthamel-wf merged commit e504a05 into Workiva:master Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonypagnotta-wf anthonypagnotta-wf anthonypagnotta-wf approved these changes

Assignees
No one assigned
Labels
Merge Requirements Met
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@chriskempf-wf @aviary-wf @robertsheehy-wf @anthonypagnotta-wf @stevenosborne-wf @colefeisthamel-wf @rmconsole-wf