Add Rest client middleware with unit tests #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RavenNumber of Findings: 0 |
| @@ -33,10 +34,45 @@ const ( | |||
| httpPut = "PUT" | |||
| ) | |||
|
|
|||
| type InvocationHandler func(c *http.Client, method, url string, body interface{}, header http.Header) (*Response, error) | |||
|
Could use some docstrings but otherwise lgtm. |
| @@ -34,10 +34,13 @@ const ( | |||
| httpPut = "PUT" | |||
| ) | |||
|
|
|||
| // The type that is the function that is to be wrapped by the ClientMiddleware | |||
| type InvocationHandler func(c *http.Client, method, url string, body interface{}, header http.Header) (*Response, error) | |||
There was a problem hiding this comment.
This is a nit, but Go docstrings should start with the name of the type/function/struct/etc. https://blog.golang.org/godoc-documenting-go-code
There was a problem hiding this comment.
Thanks for the link, I've updated the docstrings and will try and keep it in mind for future use.
|
+1 looks great |
|
+1 |
1 similar comment
|
+1 |
|
RM +1 verified dependencies manually |
|
QA review can be found here: https://jira.atl.workiva.net/browse/RM-16257 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r: @tylertreat-wf
o: @macleodbroad-wf @beaulyddon-wf @joestrach-wf