This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 39
Add info needed to add Furious to the public pypi #163
Merged
beaulyddon-wf
merged 2 commits into
Workiva:master
from
beaulyddon-wf:add_public_pypi_info
Jun 2, 2015
Merged
Add info needed to add Furious to the public pypi #163
beaulyddon-wf
merged 2 commits into
Workiva:master
from
beaulyddon-wf:add_public_pypi_info
Jun 2, 2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Furious is open source we should be good people and add our lib to pypi so others can easily use it via pip/easy_install and not be required to build from source. I've added the required info to setup.py and setup.cfg. Wasn't much. Also added the generated pypi files to the .gitignore so we don't push those up.
+1 |
2 similar comments
+1 |
+1 |
@@ -21,16 +21,17 @@ def get_version(): | |||
author_email='[email protected]', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be a good time to update this to workiva.com, and the url to Workiva
Updated info. Can I get follow up reviews ... |
+1 |
3 similar comments
+1 |
+1 |
+1 |
beaulyddon-wf
added a commit
that referenced
this pull request
Jun 2, 2015
Add info needed to add Furious to the public pypi
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Furious is open source we should be good people and add our lib to pypi so
others can easily use it via pip/easy_install and not be required to build from
source.
I've added the required info to setup.py and setup.cfg. Wasn't much. Also added
the generated pypi files to the .gitignore so we don't push those up.
@robertkluin @nickjoyce-wf @shawnrusaw-wf @tylertreat @tannermiller-wf
FYI @chadknight-wf for the request