insert_tasks_ignore_duplicates - New _insert_tasks_ignore_duplicate_name...

[markshaule-wf]

...s to gracefully handle DuplicateTaskNameError exceptions raised by inserts.

@beaulyddon-wf @tannermiller-wf @robertkluin

FYI: @erikpetersen-wf @jasonaguilon-wf @macleodbroad-wf

1. Let me know if you guys would prefer to just modify the existing _insert_tasks function, and add another option.
2. Should we add an options that just selects the _insert_tasks_ignore_duplicate_names automatically, which shields the implementation from the user.

Right now a typical usage would be:

    with context.new(batch_size=100,
                     insert_tasks=insert_tasks_ignore_duplicate_names) as ctx:
      ctx.add(...) 

[beaulyddon-wf]

I think it's fine passing in the method like this. One thing we may want to do though is move this new method out of the contexts file and create a module for task insertion handling. That way we can give users a module with some different choices for handling the task insertion without having to dig through Furious internals.

[markshaule-wf]

@beaulyddon-wf - Agreed - it doesn't feel right to be using an _insert_... directly.
Perhaps a new file in extras package, and we can rename to insert_tasks_ignore_duplicate_names

[beaulyddon-wf]

yeah. or insert_task_handlers or something to that effect. In case we want to build out other methods. But yeah extras is a good spot for it.

[markshaule-wf]

@beaulyddon-wf - Moved new function to furious/extras/insert_task_handlers.py

[beaulyddon-wf]

Cool. I like that. +1

[tylertreat-wf]

+1

[macleodbroad-wf]

in python 2.7 mock isn't part of the standard library.

[markshaule-wf]

Alright - I'll move down and group with google.

[macleodbroad-wf]

+1

[tannermiller-wf]

+1

[markshaule-wf]

@macleodbroad-wf - comments addressed regarding imports and blank lines.

[macleodbroad-wf]

+1

[tannermiller-wf]

+1

[macleodbroad-wf]

+1