This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
Transient error retry on start #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o retry_transient_errors False. Renamed parameter in _insert_tasks 'retry_errors' to 'retry_transient_errors' for clarity. Pass retry_transient_errors parameter onto recursive calls in _insert_tasks when we are splitting and retrying errors.
… to re-add a task in Async.start() method. Add option to override retry of TransientErrors in the Async.start() method
…ansactional=True has been specified in context, or Async.start()
…ent_error_retry_on_start
|
+1 |
beaulyddon-wf
added a commit
that referenced
this pull request
Jan 19, 2015
…tart Transient error retry on start
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-opened PR against Workiva/furious
Original PR here: markshaule-wf#1
Async Changes:
Async.start() now sleeps before attempting to re-add task on a TransientError.
Add option retry_transient_errors to override the retry behaviour in Async.start(). False can be specified to just re-raise the TransientError, and not attempt a retry.
Context Changes:
Context _insert_tasks now re-raises TransientError if retry option has been set to False.
Renamed parameter 'retry_errors' to 'retry_transient_errors' in _insert_tasks function.
_insert_tasks - retry_transient_errors parameter is now passed onto recursive calls correctly.
Notes on compatibility:
Since I've renamed the parameter for _insert_tasks, that could potentially break someone's custom implementation of that function.