-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0.2 return non zero for bad usage #79
2.0.2 return non zero for bad usage #79
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@corwinsheahan-wf could you add a changelog entry?
@evanweible-wf Done |
Just noticed that the GitHub CI checks aren't running because we hadn't switched over from Travis CI on v2 yet. Tried running the tests locally, but I'm seeing some failures.. looking into it |
@@ -16,11 +16,13 @@ import 'dart:io' show exit, stderr, stdout; | |||
|
|||
import 'package:args/args.dart'; | |||
import 'package:dependency_validator/dependency_validator.dart'; | |||
import 'package:io/io.dart'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a dependency in v2, so we need to add it:
io: ^0.3.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
QA +1
@Workiva/release-management-p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Motivation
Back patch of this PR to the 2.x release line.
Changes
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: