Update analyzer constraint #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
Ghabs95
approved these changes
May 26, 2024
matthewnitschke-wk
approved these changes
May 30, 2024
|
@Attempt3035 Approach seems fine, looking at the changelog for v6 there's nothing that should effect dependency_validator, and we should catch any issues from the existing unit tests within the repo (we run on both dart 2 and 3) CI failures are unrelated to this change, and were fixed here: #120, If you just merge master on this pr, we can re-run CI and get this merged! Thanks for putting the PR up! |
matthewnitschke-wk
approved these changes
Jun 3, 2024
|
QA +1
🚀 @Workiva/release-management-p 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I noticed analyzer was being resolved to a lower version than available, it's causing warnings in the build runner for freezed.
Changes
I opened the depended-on analyzer versions to include the 6.#.# major release, but less than 7.#.# (Not out yet anyway)
Testing/QA Instructions
I have no idea the implications this may have, and have not looked around this code base. From my testing, everything is operating normally as far as I can see, but this would need a maintainer to run some tests to confirm. I checked the changes in the analyzer package version notes, they seem minimal and I'm guessing won't affect anything with this package :)