Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEDX-687 : GHA OSS changes to dependency_validator #110

Merged
merged 3 commits into from
Apr 5, 2024
Merged

FEDX-687 : GHA OSS changes to dependency_validator #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e72bd28
FEDX-687 : GHA OSS changes to dependency_validator
alishadalal-wk Apr 3, 2024
e0acc67
FEDX-687 : Remove 2.18 from CI matrix
alishadalal-wk Apr 3, 2024
81e5deb
fix build_config issue in tests
robbecker-wf Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/dart_ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
sdk: [ 2.18.7, 2.19.6 ]
sdk: [ 2.19.6 ]
steps:
- uses: actions/checkout@v2
- uses: dart-lang/setup-dart@v1
Expand All @@ -31,3 +31,7 @@ jobs:
run: dart analyze
- name: Run tests
run: dart test
- uses: anchore/sbom-action@v0
with:
path: ./
format: cyclonedx-json
1 change: 0 additions & 1 deletion Dockerfile
View file
Open in desktop

This file was deleted.

13 changes: 0 additions & 13 deletions skynet.yaml
View file
Open in desktop

This file was deleted.

30 changes: 19 additions & 11 deletions test/executable_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@ import 'package:io/io.dart';
import 'package:test/test.dart';
import 'package:test_descriptor/test_descriptor.dart' as d;

/// `master` on build_config has a min sdk bound of dart 3.0.0.
/// Since dependency_validator is still designed to be used on dart 2
/// code, we still want to run unit tests using this older version
///
/// The following ref, is the last commit in build_config that allowed
/// dart 2 as a dependency
const buildConfigRef = 'e2c837b48bd3c4428cb40e2bc1a6cf47d45df8cc';

ProcessResult checkProject(String projectPath,
{List<String> optionalArgs = const []}) {
final pubGetResult =
Expand Down Expand Up @@ -65,7 +73,7 @@ void main() {
git:
url: https://github.com/dart-lang/build.git
path: build_config
ref: master
ref: $buildConfigRef
''');

final fakeProjectBuild = unindent('''
Expand Down Expand Up @@ -134,7 +142,7 @@ void main() {
git:
url: https://github.com/dart-lang/build.git
path: build_config
ref: master
ref: $buildConfigRef
''');

await d.dir('missing', [
Expand Down Expand Up @@ -241,7 +249,7 @@ void main() {
git:
url: https://github.com/dart-lang/build.git
path: build_config
ref: master
ref: $buildConfigRef
''');

await d.dir('over_promoted', [
Expand Down Expand Up @@ -312,7 +320,7 @@ void main() {
git:
url: https://github.com/dart-lang/build.git
path: build_config
ref: master
ref: $buildConfigRef
''');

await d.dir('under_promoted', [
Expand Down Expand Up @@ -384,7 +392,7 @@ void main() {
git:
url: https://github.com/dart-lang/build.git
path: build_config
ref: master
ref: $buildConfigRef
''');

await d.dir('unused', [
Expand Down Expand Up @@ -452,7 +460,7 @@ void main() {
git:
url: https://github.com/dart-lang/build.git
path: build_config
ref: master
ref: $buildConfigRef
''');

await d.dir('project', [
Expand Down Expand Up @@ -496,7 +504,7 @@ void main() {
git:
url: https://github.com/dart-lang/build.git
path: build_config
ref: master
ref: $buildConfigRef
''');

final validDotDart = ''
Expand Down Expand Up @@ -537,7 +545,7 @@ void main() {
git:
url: https://github.com/dart-lang/build.git
path: build_config
ref: master
ref: $buildConfigRef
''');

await d.dir('common_binaries', [
Expand Down Expand Up @@ -573,7 +581,7 @@ void main() {
git:
url: https://github.com/dart-lang/build.git
path: build_config
ref: master
ref: $buildConfigRef
''');

await d.dir('common_binaries', [
Expand Down Expand Up @@ -607,7 +615,7 @@ void main() {
git:
url: https://github.com/dart-lang/build.git
path: build_config
ref: master
ref: $buildConfigRef
''');

final build = unindent(r'''
Expand Down Expand Up @@ -650,7 +658,7 @@ void main() {
git:
url: https://github.com/dart-lang/build.git
path: build_config
ref: master
ref: $buildConfigRef
''');

await d.dir('dependency_pins', [
Expand Down
Loading