Add community rough templates #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iandunn
reviewed
Nov 26, 2021
| global $wp_query; | ||
|
|
||
| // Add first-in-year and last-in-year to help put design elements in between year groups in the Month In WordPress category | ||
| if ( is_object( $wp_query ) && $wp_query->post_count > 1 ) { |
There was a problem hiding this comment.
I wonder if the post-year-{date} is enough to achieve this? Maybe something like this for the SVG "separator" image between years?
[class*="post-year-"]:last-of-type {
content: "";
background-image: url( 'images/foo.svg' );
}Since post-year- is targeted with a wildcard, it should match the last instance of post-year-2021, post-year-2020, etc.
There was a problem hiding this comment.
Yeah that might work, thanks! I'll leave in the first-in-year code in place for now with a note to remove it if it's not ultimately needed.
This doesn't work but it's surely part of the solution. I'm not sure what the blocker is here.
tellyworth
added a commit
that referenced
this pull request
Nov 29, 2021
This uses the `category` pseudo-attribute from #88.
tellyworth
added a commit
that referenced
this pull request
Dec 9, 2021
* Rough starting templates This is a starting point for the month-in-wordpress templates. There's no CSS changes yet, just the markup. Some notes: * The wp:query block has some limitations and oddities. I've set columns to 4 because otherwise it was only showing 2. Could be an off-by-one bug or just some quirky layout stuff. * I used perPage:10000. 0/-1 don't work like WP_Query. I'd prefer to set the limit to something like 60 (5 years per page), but it seems that the pagination block doesn't pay attention to the query block's page parameters and that would mean putting a magic number in two places. Probably there's a sensible way to handle that, but for now I've just removed the pagination altogether. * Limit the query to the right category This uses the `category` pseudo-attribute from #88. * Make headings links * Fix link colour, align text * Workaround for an issue in query handling There's a weird bug or unexpected behaviour around setting the query vars in this context. This isn't right but it'll look better for the demo. * Rough version of the in-between-years divider
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a very rough version of the Community category page.
There's lots that doesn't look right or work properly yet, but it's a starting point to work on.