Add Interactive Block Playground package #220
Conversation
| changeOrigin: true, | ||
| secure: true, | ||
| }, | ||
| '/plugin-proxy': { |
There was a problem hiding this comment.
For later – a standard vite config with these endpoints in place would be super useful
| @@ -0,0 +1,19 @@ | |||
| { | |||
There was a problem hiding this comment.
CI won't be happy until this mimics tsconfig setup from other projects: three tsconfig.json files and a reference in the root tsconfig.base.json.
There was a problem hiding this comment.
done b432c70 👍
There was a problem hiding this comment.
Although, I'm not sure if that's entirely correct. I've now removed the reference in
the base tsconfig.json because I was getting a referenced project must have composite:true TS error here.
The tsconfig files are just copied over from the website package. As far as I
can see the website package does not have the reference in the base tsconfig.
There was a problem hiding this comment.
I was getting a referenced project must have composite:true TS error here.
That seems like a bug: nrwl/nx#4508
Looks like it can be fixed by having a step called build in project.json – which is a good idea anyway if this is to benefit from all the build-related automations (e.g. CI build checks).
As far as I can see the website package does not have the reference in the base tsconfig.
Ah, that was an oversight – thanks! I just fixed it in 82386e7
| return new DOMParser().parseFromString(response.text, 'text/html')!; | ||
| } | ||
|
|
||
| async function createNewPost( |
There was a problem hiding this comment.
Follow-up: This would make a great Blueprint step
There was a problem hiding this comment.
Opened a separate PR for this: #234. Once that one is merged, I can just use the step in this package.
|
@michalczaplinski this is great! I left a few nits for now and a few follow-up tasks for later – I'm happy to merge this as soon as CI is great and the nits are addressed. I know the code is quite messy, but it's still a |
Co-authored-by: Adam Zielinski <[email protected]>
Co-authored-by: Adam Zielinski <[email protected]>
michalczaplinski
force-pushed
the
interactive-block-editor
branch
from
a2d583b
to
2f6ff6a
Compare
|
Hey @adamziel I think I've addressed all the nits now and made the CI pass. Do you wanna give it another review? |
michalczaplinski
changed the title
|
@michalczaplinski looking good! I added a suggestion to clean up Also, I just landed the Interactive Code Block today which ships with a CodeMirror React component and some utilities to build WordPress plugins. Let's look into reusing some of these bits once this one is merged. |
Accept changes from Adam Co-authored-by: Adam Zielinski <[email protected]>
|
@adamziel and I updated the So, now you can do for example: {
step: 'installPlugin',
pluginZipFile: {
resource: 'url',
url: '/plugin-proxy?repo=WordPress/block-interactivity-experiments&name=block-interactivity-experiments.zip',
}
}Done in ed5c11f |
Bringing the https://github.com/michalczaplinski/interactive-block-playground into this repo.
Screen.Recording.2023-04-27.at.20.51.30.mov
Opening this early, even though:
nxandviteincorrectly.playgroundOriginlike the website does here.nxtask to watch & rebuild the plugins and zip them so thatbuild-zips.cjsworksYou can try it out it with
npm run dev:editorfrom the repo root.