Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twenty Twelve: Move skip link to be first focusable element #8328

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

himanshupathak95
Copy link

@himanshupathak95 himanshupathak95 commented Feb 15, 2025

Trac ticket: https://core.trac.wordpress.org/ticket/62967

This PR fixes an accessibility issue in the Twenty Twelve theme by moving the "Skip to content" link to be the first focusable element on the page. No changes to the link's functionality or styling.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@himanshupathak95 himanshupathak95 marked this pull request as ready for review February 15, 2025 11:35
Copy link

github-actions bot commented Feb 15, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props abcd95, sabernhardt.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Comment on lines 36 to 38
<a class="assistive-text" href="#content"><?php _e( 'Skip to content', 'twentytwelve' ); ?></a>
<div id="page" class="hfeed site">
<header id="masthead" class="site-header">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a class="assistive-text" href="#content"><?php _e( 'Skip to content', 'twentytwelve' ); ?></a>
<div id="page" class="hfeed site">
<header id="masthead" class="site-header">
<div id="page" class="hfeed site">
<a class="screen-reader-text skip-link" href="#content"><?php _e( 'Skip to content', 'twentytwelve' ); ?></a>
<header id="masthead" class="site-header">
  1. I prefer placing the link inside the "page" div (as Twenty Fifteen and some later bundled themes do). If someone uses a link to #page, then the skip link would be the first item.
  2. If you also change the assistive-text class to screen-reader-text, Twenty Twelve already has styles for .site .screen-reader-text:focus. Then style.css would not need any editing.

@himanshupathak95
Copy link
Author

Hey @sabernhardt Thanks for the suggestions!

I have also updated the changes and moved the skip links inside the page div for the Twenty Thirteen and Twenty Fourteen themes. Please let me know if the changes look good to you whenever you have time.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants