-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twenty Twelve: Move skip link to be first focusable element #8328
base: trunk
Are you sure you want to change the base?
Twenty Twelve: Move skip link to be first focusable element #8328
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
<a class="assistive-text" href="#content"><?php _e( 'Skip to content', 'twentytwelve' ); ?></a> | ||
<div id="page" class="hfeed site"> | ||
<header id="masthead" class="site-header"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<a class="assistive-text" href="#content"><?php _e( 'Skip to content', 'twentytwelve' ); ?></a> | |
<div id="page" class="hfeed site"> | |
<header id="masthead" class="site-header"> | |
<div id="page" class="hfeed site"> | |
<a class="screen-reader-text skip-link" href="#content"><?php _e( 'Skip to content', 'twentytwelve' ); ?></a> | |
<header id="masthead" class="site-header"> |
- I prefer placing the link inside the "page"
div
(as Twenty Fifteen and some later bundled themes do). If someone uses a link to#page
, then the skip link would be the first item. - If you also change the
assistive-text
class toscreen-reader-text
, Twenty Twelve already has styles for.site .screen-reader-text:focus
. Thenstyle.css
would not need any editing.
Hey @sabernhardt Thanks for the suggestions! I have also updated the changes and moved the skip links inside the page Thanks. |
Trac ticket: https://core.trac.wordpress.org/ticket/62967
This PR fixes an accessibility issue in the Twenty Twelve theme by moving the "Skip to content" link to be the first focusable element on the page. No changes to the link's functionality or styling.