Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML API: phpstan check #7805

Draft
wants to merge 6 commits into
base: trunk
Choose a base branch
from
Draft

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Nov 14, 2024

composer install
./vendor/bin/phpstan --memory-limit=4G analyze
  ------ ----------------------------------------------------------------------------- 
  Line   html-api/class-wp-html-decoder.php                                           
 ------ ----------------------------------------------------------------------------- 
  69     Variable $token_length might not be defined.                                 
         🪪  variable.undefined                                                       
  149    Variable $character_reference in isset() always exists and is not nullable.  
         🪪  isset.variable                                                           
 ------ ----------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------- 
  Line   html-api/class-wp-html-processor-state.php                                                    
 ------ ---------------------------------------------------------------------------------------------- 
  366    PHPDoc tag @var has invalid value ([string, array]|null): Unexpected token "]", expected '('  
         at offset 202 on line 8                                                                       
         🪪  phpDoc.parseError                                                                         
 ------ ---------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------- 
  Line   html-api/class-wp-html-processor.php                                                           
 ------ ----------------------------------------------------------------------------------------------- 
  300    Unsafe usage of new static().                                                                  
         🪪  new.static                                                                                 
         💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static              
  351    Unsafe usage of new static().                                                                  
         🪪  new.static                                                                                 
         💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static              
  917    Method WP_HTML_Processor::step() should return bool but return statement is missing.           
  3016   Variable $node might not be defined.                                                           
         🪪  variable.undefined                                                                         
  3022   Variable $node might not be defined.                                                           
         🪪  variable.undefined                                                                         
  3286   Method WP_HTML_Processor::step_in_table() should return bool but return statement is missing.  
  3305   Method WP_HTML_Processor::step_in_table_text() should return bool but return statement is      
         missing.                                                                                       
  3917   Variable $parent might not be defined.                                                         
         🪪  variable.undefined                                                                         
  5693   Method WP_HTML_Processor::reconstruct_active_formatting_elements() should return bool but      
         return statement is missing.                                                                   
 ------ ----------------------------------------------------------------------------------------------- 

 ------ --------------------------------------------------------------------- 
  Line   html-api/class-wp-html-tag-processor.php                             
 ------ --------------------------------------------------------------------- 
  1603   Variable $closer_potentially_starts_at might not be defined.         
         🪪  variable.undefined                                               
  1604   Variable $closer_potentially_starts_at might not be defined.         
         🪪  variable.undefined                                               
  3508   Variable $replacement in isset() always exists and is not nullable.  
         🪪  isset.variable                                                   
  3875   Function wp_kses_uri_attributes not found.                           
         🪪  function.notFound                                                
         💡 Learn more at https://phpstan.org/user-guide/discovering-symbols  
 ------ --------------------------------------------------------------------- 

 [ERROR] Found 17 errors                                                                                


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant