51423: AtomParser: fixes PHP 8 fatal error in wp-includes/atomlib.php #718
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/51423
Split of the larger PR for this commit.
tl;dr
This change guards Core while ensuring 3rd party developers continue to be alerted to the problem from
fopen
Warning
.AtomParser::parser()
from PHP 8 fatal error when/ifAtomParser::FILE
is ever changed to an invalid or unavailable resource.fopen
to alert 3rd party developer of an invalid/unavailable resource.fread
andfclose
.fopen
will throw aWarning
. The additional warnings are due to the initial problem atfopen
.Risk:
More Details
When
AtomParser::FILE
is not changedThis change is not needed if the property
AtomParser::FILE
is not changed.Why?
By default,
AtomParser::FILE
is set tophp://input
for the read-only stream.fopen
will return the resource pointer for the stream.fread
returns an empty stringfclose
closes the resource pointer.What if the property
AtomParser::FILE
is changed?If valid and available,
fopen
returns the resource. Same behavior as above.AtomParser::FILE
is invalid or unavailableIf invalid/unavailable,
fopen
returnsfalse
and throws aWarning
in PHP 5, 7, and 8. See it in action here https://3v4l.org/pYKdD.This behavior is the same in all PHP versions. We don't need to do anything for PHP 8.
What about
fread
andfclose
?See it in action here https://3v4l.org/HhApV.
fopen
returnedfalse
.fread
andfclose
throws:TODO
- [ ] Add code coverage for theThere's no code coverage for the external library.AtomParser::parse()
.This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.