KSES: Replace attribute parsing with HTML API. #6572
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this patch several kses functions have been rewritten to rely on the spec-compliant parsing made available in the HTML API. These functions convert HTML input into an array of parsed attribute values. By relying on the HTML API it's possible to recognize the HTML in the same way that a browser would, removing a layer of custom interpretation, full of discrepancies and bugs.