Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages 65 no nav changes #5967

Closed

Conversation

getdave
Copy link
Contributor

@getdave getdave commented Jan 29, 2024

Trac ticket:

Debugging for #5922 as suggested in #5922 (comment)


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@getdave getdave force-pushed the update/packages-65-no-nav-changes branch from 3f75a59 to 01e66ea Compare January 29, 2024 14:56
@getdave
Copy link
Contributor Author

getdave commented Jan 29, 2024

Rather than reverting the changes to src/wp-includes/blocks/navigation-link.php entirely, I'm now trying to target specific lines to determine the root cause.

@getdave
Copy link
Contributor Author

getdave commented Jan 29, 2024

I manually applied the code changes from WordPress/gutenberg#58389 and this has resolved the error in the two lines I identified as the source of the problem in 01e66ea.

Let's try and bring that PR into Gutenberg and then update @youknowriad's package sync PR.

@getdave
Copy link
Contributor Author

getdave commented Jan 31, 2024

As this was only for debugging the actions we can close this out.

@getdave getdave closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants