-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update caniuse
and regenerate CSS
#5939
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
@desrosj Do we need |
@mukeshpanchal27 In this case, yes. The package that needs to be updated is not a direct dependency, so it's only defined within the lock file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Everything looks good. @sirreal, was it necessary for anything related to bundling Interactivity code?
Yes, we hit problems and cherry-picked the package-lock changes here to unblock this work: #5922 (comment) When this PR lands that removes a blocker 👍 |
I'm going to commit this since this blocks other work and is a reasonable change to make. But I do have some concerns around the frequent churn related to these updates has caused recently. I documented these changes on the Trac ticket. |
Trac ticket: https://core.trac.wordpress.org/ticket/59657.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.