HTML API: Stop proceeding HTML when encountering unsupported markup. #5048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was a design goal of the HTML Processor to abort processing its input document when encountering unsupported markup. Unfortunately there was no test for this and so-far, the HTML Processor has paused, but continued processing in these situations. In this patch a new test ensures that the HTML Processor stops and refuses to move forward after encountering any unsupported markup. It also ensures that it doesn't report any current tag names since unsupported markup could imply that the read tag name is different than the parsed tag name.
dmsnell
added a commit
to WordPress/gutenberg
that referenced
this pull request
Aug 22, 2023
…ted markup WordPress/wordpress-develop#5048 fixes a bug where the HTML Processor continues to process input HTML once it encounters unsupported markup, which it shouldn't. It should stop and abort all processing.
|
Committed to Core in https://core.trac.wordpress.org/changeset/56493. |
dmsnell
added a commit
to WordPress/gutenberg
that referenced
this pull request
Sep 1, 2023
…ted markup WordPress/wordpress-develop#5048 fixes a bug where the HTML Processor continues to process input HTML once it encounters unsupported markup, which it shouldn't. It should stop and abort all processing.
dmsnell
added a commit
to WordPress/gutenberg
that referenced
this pull request
Sep 5, 2023
…ted markup WordPress/wordpress-develop#5048 fixes a bug where the HTML Processor continues to process input HTML once it encounters unsupported markup, which it shouldn't. It should stop and abort all processing.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: #59167-trac
It was a design goal of the HTML Processor to abort processing its input document when encountering unsupported markup. Unfortunately there was no test for this and so-far, the HTML Processor has paused, but continued processing in these situations.
In this patch a new test ensures that the HTML Processor stops and refuses to move forward after encountering any unsupported markup. It also ensures that it doesn't report any current tag names since unsupported markup could imply that the read tag name is different than the parsed tag name.