Editor: Move printing TinyMCE scripts into an action #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
commented
Apr 21, 2020
Closed
6 tasks
Moving this logic into an action allows plugins to override how/when TinyMCE is loaded. Specifically, Gutenberg needs to be able to prevent TinyMCE scripts from being written into the page when TinyMCE should be loaded asynchronously when it is actually needed.
…t handle Based on WordPress/gutenberg#21244 but pulled into Core so that this functionality can be used when retriving the URIs for TinyMCE's dependencies when it is being asynchronously loaded.
6 tasks
This is necessary in order to support lazily loading TinyMCE for the classic block. Because some custom meta boxes may depend on TinyMCE, if they are present we must pre-load TinyMCE as normal. To be able to support making that decision at runtime, we need to have already processed and initialized the `$wp_meta_boxes` global when we call to wp_enqueue_editor, which the Gutenberg plugin hooks into through a new action also added as part of this patch to programatically decide whether or not TinyMCE needs to be pre-loaded.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR to start addressing the issue in the ticket. Moving this logic into an action allows plugins to override how/when TinyMCE is loaded. Specifically, Gutenberg needs to be able to prevent TinyMCE scripts from being written into the page when TinyMCE should be loaded asynchronously when it is actually needed.
This is the first time I've made changes in WordPress core and I had a hard time deciding where to put the
wp_print_tinymce_scriptsfunction (or what to name it, for that matter).I'm also not even sure that this is exactly the correct approach for the issue described in the ticket, so any and all feedback is super welcome!
Trac ticket: https://core.trac.wordpress.org/ticket/49964
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.