Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement WP admin UI for plugin dependencies #1547

Closed
wants to merge 51 commits into from
Closed

Implement WP admin UI for plugin dependencies #1547

wants to merge 51 commits into from

Commits on Sep 20, 2021

  1. Implement plugin dependencies using a JSON file.

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    2d7e62d View commit details
    Browse the repository at this point in the history

  2. move the position of require_once 

    props @SergeyBiryukov
    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    d5dec73 View commit details
    Browse the repository at this point in the history

  3. Coding-standards fix

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    0215b46 View commit details
    Browse the repository at this point in the history

  4. Use plugin headers instead of JSON file

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    c4cec75 View commit details
    Browse the repository at this point in the history

  5. Use str_getcsv

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    750c5b4 View commit details
    Browse the repository at this point in the history

  6. Early exit if DISALLOW_FILE_MODS is enabled

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    80c58f3 View commit details
    Browse the repository at this point in the history

  7. Early exit it DISALLOW_PLUGIN_DEPENDENCIES is enabled.

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    de8f452 View commit details
    Browse the repository at this point in the history

  8. combine checks

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    b7e4b47 View commit details
    Browse the repository at this point in the history

  9. handle circular dependencies

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    af43339 View commit details
    Browse the repository at this point in the history

  10. Improve plugin rows notices

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    480d9a9 View commit details
    Browse the repository at this point in the history

  11. Update src/wp-admin/includes/class-wp-plugin-dependencies.php 

    Co-authored-by: Denis Žoljom <[email protected]>
    @aristath @dingo-d
    aristath and dingo-d committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    e1ec703 View commit details
    Browse the repository at this point in the history

  12. Add extra text for circular dependencies

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    89fb76e View commit details
    Browse the repository at this point in the history

  13. improve styling

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    ba02dae View commit details
    Browse the repository at this point in the history

  14. Add phpcs exception

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    dcc8f6e View commit details
    Browse the repository at this point in the history

  15. improve readability

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    41409d0 View commit details
    Browse the repository at this point in the history

  16. Add inline comment

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    9c3d199 View commit details
    Browse the repository at this point in the history

  17. mark object vars as private

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    d81677b View commit details
    Browse the repository at this point in the history

  18. tweak visibility for methods

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    babbe6c View commit details
    Browse the repository at this point in the history

  19. use a class const for the option-name

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    794b4fc View commit details
    Browse the repository at this point in the history

  20. add doc for return

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    b15adc6 View commit details
    Browse the repository at this point in the history

  21. phpcbf

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    1959a45 View commit details
    Browse the repository at this point in the history

  22. Add extra check, get_plugin_file_from_slug can be false

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    f2df25e View commit details
    Browse the repository at this point in the history

  23. more styling tweaks

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    00ca137 View commit details
    Browse the repository at this point in the history

  24. properly detect if plugin is active

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    90ed6cb View commit details
    Browse the repository at this point in the history

  25. more styling tweaks

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    528c09e View commit details
    Browse the repository at this point in the history

  26. explicitly mention that dependencies can't be deactivated.

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    fffdcc9 View commit details
    Browse the repository at this point in the history

  27. Add has_unmet_dependencies

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    b809cf5 View commit details
    Browse the repository at this point in the history

  28. partially revert previous commit

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    19790d9 View commit details
    Browse the repository at this point in the history

  29. method no longer needs to return anything

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    0cbd6a8 View commit details
    Browse the repository at this point in the history

  30. Revert "method no longer needs to return anything" 

    This reverts commit 39fdd6c.
    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    2c11b63 View commit details
    Browse the repository at this point in the history

  31. Revert "partially revert previous commit" 

    This reverts commit 024c9c3.
    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    cf7bdf6 View commit details
    Browse the repository at this point in the history

  32. Revert "Add has_unmet_dependencies" 

    This reverts commit bdb9683.
    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    1cdea86 View commit details
    Browse the repository at this point in the history

  33. This is no longer used

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    c4c4ec7 View commit details
    Browse the repository at this point in the history

  34. minor improvements

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    849172b View commit details
    Browse the repository at this point in the history

  35. allow defining the notice type

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    f04ceef View commit details
    Browse the repository at this point in the history

  36. minor refactor

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    3d7af17 View commit details
    Browse the repository at this point in the history

  37. Minor class wp dependencies fixes 

    Added types to the parameters, removed unused code, fixed phpcs issues
    @dingo-d @aristath
    dingo-d authored and aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    141028b View commit details
    Browse the repository at this point in the history

  38. We only need 2 params here

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    b1d7408 View commit details
    Browse the repository at this point in the history

  39. fix @SInCE

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    c3cead7 View commit details
    Browse the repository at this point in the history

  40. fix comments alignment

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    4edbc54 View commit details
    Browse the repository at this point in the history

  41. remove box-shadow

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    e5afbc6 View commit details
    Browse the repository at this point in the history

  42. fix PHP warnings

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    0c8d01a View commit details
    Browse the repository at this point in the history

  43. Hide checkbox if plugin can't be deactivated.

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    fe99208 View commit details
    Browse the repository at this point in the history

  44. fix notice for active dependency

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    f2779af View commit details
    Browse the repository at this point in the history

  45. Disable checkbox instead of removing it

    @aristath
    aristath committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    209ee36 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2021

  1. Update src/wp-admin/includes/class-wp-plugin-dependencies.php 

    Co-authored-by: Peter Wilson <[email protected]>
    @aristath @peterwilsoncc
    aristath and peterwilsoncc authored Sep 21, 2021
    Configuration menu
    Copy the full SHA
    1183af5 View commit details
    Browse the repository at this point in the history

  2. prefer protected over private

    @aristath
    aristath committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    f671369 View commit details
    Browse the repository at this point in the history

  3. Update src/wp-admin/includes/class-wp-plugin-dependencies.php 

    Co-authored-by: Peter Wilson <[email protected]>
    @aristath @peterwilsoncc
    aristath and peterwilsoncc authored Sep 21, 2021
    Configuration menu
    Copy the full SHA
    d87d8d8 View commit details
    Browse the repository at this point in the history

  4. global was renamed

    @aristath
    aristath committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    8948025 View commit details
    Browse the repository at this point in the history

  5. tweak for namespaced plugins

    @aristath
    aristath committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    1d795d8 View commit details
    Browse the repository at this point in the history

  6. missed a comma

    @aristath
    aristath committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    abde99e View commit details
    Browse the repository at this point in the history