Skip to content

Add the pattern name to pattern blocks when they are converted #10180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scruffian wants to merge 3 commits into from
Closed

Add the pattern name to pattern blocks when they are converted #10180

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3154de0
Add the pattern name to pattern blocks when they are converted
scruffian Oct 7, 2025
4993cf1
Trim pattern content and constrain to single root-block patterns
ramonjd Oct 14, 2025
f418cf6
Lint
ramonjd Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/wp-includes/blocks.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1869,8 +1869,12 @@
++$i;
continue;
}

$blocks_to_insert = parse_blocks( $pattern['content'] );

// Add the pattern name to make this a pattern instance in the editor.
if( count( $blocks_to_insert ) === 2 ) { // should be 1 but we seem to have an empty block always

Check failure on line 1875 in src/wp-includes/blocks.php

View workflow job for this annotation

GitHub Actions / Coding standards / PHP checks 

Expected 1 space after IF keyword; 0 found

Check failure on line 1875 in src/wp-includes/blocks.php

View workflow job for this annotation

GitHub Actions / Coding standards / PHP checks 

No space before opening parenthesis is prohibited

Check failure on line 1875 in src/wp-includes/blocks.php

View workflow job for this annotation

GitHub Actions / Coding standards / PHP checks 

Space after opening control structure is required
Comment thread
ramonjd marked this conversation as resolved.
Outdated
$blocks_to_insert[0]['attrs']['metadata'] = [ 'patternName' => $slug, 'name' => $pattern['title'] ];

Check failure on line 1876 in src/wp-includes/blocks.php

View workflow job for this annotation

GitHub Actions / Coding standards / PHP checks 

When a multi-item array uses associative keys, each value should start on a new line.

Check failure on line 1876 in src/wp-includes/blocks.php

View workflow job for this annotation

GitHub Actions / Coding standards / PHP checks 

Short array syntax is not allowed
}
$seen_refs[ $slug ] = true;
$prev_inner_content = $inner_content;
$inner_content = null;
Expand Down
Loading