Twenty Twenty: Remove various unused function parameters and variables.

This removes the `$n` variable from `TwentyTwenty_Walker_Page` class `start_el()` function, removes an unused global and the last parameter from 
`twentytwenty_filter_wp_list_pages_item_classes()` and `twentytwenty_add_sub_toggles_to_main_menu()`.

Props upadalavipul, sabernhardt, mukesh27.
Fixes #57371.




git-svn-id: https://develop.svn.wordpress.org/trunk@56045 602fd350-edb4-49c9-b593-d223f7449a82

src/wp-content/themes/twentytwenty/classes/class-twentytwenty-walker-page.php

@@ -38,10 +38,8 @@ public function start_el( &$output, $data_object, $depth = 0, $args = array(), $
 
 			if ( isset( $args['item_spacing'] ) && 'preserve' === $args['item_spacing'] ) {
 				$t = "\t";
-				$n = "\n";
 			} else {
 				$t = '';
-				$n = '';
 			}
 			if ( $depth ) {
 				$indent = str_repeat( $t, $depth );

src/wp-content/themes/twentytwenty/inc/template-tags.php

@@ -241,8 +241,6 @@ function twentytwenty_edit_post_link( $link, $post_id, $text ) {
  *
  * @since Twenty Twenty 1.0
  *
- * @global WP_Post $post Global post object.
- *
  * @param int    $post_id  The ID of the post.
  * @param string $location The location where the meta is shown.
  */
@@ -331,7 +329,6 @@ function twentytwenty_get_post_meta( $post_id = null, $location = 'single-top' )
 		// Make sure we don't output an empty container.
 		$has_meta = false;
 
-		global $post;
 		$the_post = get_post( $post_id );
 		setup_postdata( $the_post );
 
@@ -545,10 +542,9 @@ function twentytwenty_get_post_meta( $post_id = null, $location = 'single-top' )
  * @param WP_Post  $page         Page data object.
  * @param int      $depth        Depth of page, used for padding.
  * @param array    $args         An array of arguments.
- * @param int      $current_page ID of the current page.
  * @return array CSS class names.
  */
-function twentytwenty_filter_wp_list_pages_item_classes( $css_class, $page, $depth, $args, $current_page ) {
+function twentytwenty_filter_wp_list_pages_item_classes( $css_class, $page, $depth, $args ) {
 
 	// Only apply to wp_list_pages() calls with match_menu_classes set to true.
 	$match_menu_classes = isset( $args['match_menu_classes'] );
@@ -571,7 +567,7 @@ function twentytwenty_filter_wp_list_pages_item_classes( $css_class, $page, $dep
 
 }
 
-add_filter( 'page_css_class', 'twentytwenty_filter_wp_list_pages_item_classes', 10, 5 );
+add_filter( 'page_css_class', 'twentytwenty_filter_wp_list_pages_item_classes', 10, 4 );
 
 /**
  * Adds a Sub Nav Toggle to the Expanded Menu and Mobile Menu.
@@ -580,10 +576,9 @@ function twentytwenty_filter_wp_list_pages_item_classes( $css_class, $page, $dep
  *
  * @param stdClass $args  An object of wp_nav_menu() arguments.
  * @param WP_Post  $item  Menu item data object.
- * @param int      $depth Depth of menu item. Used for padding.
  * @return stdClass An object of wp_nav_menu() arguments.
  */
-function twentytwenty_add_sub_toggles_to_main_menu( $args, $item, $depth ) {
+function twentytwenty_add_sub_toggles_to_main_menu( $args, $item ) {
 
 	// Add sub menu toggles to the Expanded Menu with toggles.
 	if ( isset( $args->show_toggles ) && $args->show_toggles ) {
@@ -622,7 +617,7 @@ function twentytwenty_add_sub_toggles_to_main_menu( $args, $item, $depth ) {
 
 }
 
-add_filter( 'nav_menu_item_args', 'twentytwenty_add_sub_toggles_to_main_menu', 10, 3 );
+add_filter( 'nav_menu_item_args', 'twentytwenty_add_sub_toggles_to_main_menu', 10, 2 );
 
 /**
  * Displays SVG icons in social links menu.