Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Dave Smith <[email protected]>
  • Loading branch information
ramonjd and getdave committed Feb 23, 2024
1 parent 1f8de21 commit 384607c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/phpunit/tests/theme/wpThemeJson.php
Original file line number Diff line number Diff line change
Expand Up @@ -5277,7 +5277,7 @@ public function test_resolve_variables() {
* WP_Theme_JSON_Resolver. WP_Theme_JSON_Resolver::get_block_data() sets blockGap for supported blocks to `null` if the value is not defined.
*/
$this->assertNull( $styles['blocks']['core/post-template']['spacing']['blockGap'], 'core/post-template block: blockGap', 'Post Template block's spacing blockGap should be null' );

Check failure on line 5279 in tests/phpunit/tests/theme/wpThemeJson.php

View workflow job for this annotation

GitHub Actions / PHP coding standards

Opening parenthesis of a multi-line function call must be the last content on the line

Check failure on line 5279 in tests/phpunit/tests/theme/wpThemeJson.php

View workflow job for this annotation

GitHub Actions / PHP coding standards

Only one argument is allowed per line in a multi-line function call

Check failure on line 5279 in tests/phpunit/tests/theme/wpThemeJson.php

View workflow job for this annotation

GitHub Actions / PHP coding standards

Only one argument is allowed per line in a multi-line function call
$this->assertEquals( $spacing, $styles['blocks']['core/columns']['spacing']['blockGap'], 'core/columns block: blockGap' );
$this->assertEquals( $spacing, $styles['blocks']['core/columns']['spacing']['blockGap'], 'core/columns block: blockGap', 'Columns block's spacing blockGap should match' );

Check failure on line 5280 in tests/phpunit/tests/theme/wpThemeJson.php

View workflow job for this annotation

GitHub Actions / PHP coding standards

Expected 1 space before "/"; 0 found

Check failure on line 5280 in tests/phpunit/tests/theme/wpThemeJson.php

View workflow job for this annotation

GitHub Actions / PHP coding standards

Expected 1 space after "/"; 0 found

Check failure on line 5280 in tests/phpunit/tests/theme/wpThemeJson.php

View workflow job for this annotation

GitHub Actions / PHP coding standards

Expected 1 space before "/"; 0 found

Check failure on line 5280 in tests/phpunit/tests/theme/wpThemeJson.php

View workflow job for this annotation

GitHub Actions / PHP coding standards

Expected 1 space after "/"; 0 found

Check failure on line 5280 in tests/phpunit/tests/theme/wpThemeJson.php

View workflow job for this annotation

GitHub Actions / PHP coding standards

Use of the GOTO language construct is discouraged

Check failure on line 5280 in tests/phpunit/tests/theme/wpThemeJson.php

View workflow job for this annotation

GitHub Actions / PHP coding standards

Closing parenthesis of a multi-line function call must be on a line by itself
}

/**
Expand Down

0 comments on commit 384607c

Please sign in to comment.