Build/Test Tools: Switch to some more appropriate assertions.

See #54725 git-svn-id: https://develop.svn.wordpress.org/trunk@52654 602fd350-edb4-49c9-b593-d223f7449a82
WordPress · Jan 30, 2022 · 24b83dd · 24b83dd
1 parent ffd6127
commit 24b83dd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/tests/phpunit/tests/includes/factory.php b/tests/phpunit/tests/includes/factory.php
@@ -8,12 +8,12 @@ public function set_up() {
 
 	public function test_create_creates_a_category() {
 		$id = $this->category_factory->create();
-		$this->assertTrue( (bool) get_term_by( 'id', $id, 'category' ) );
+		$this->assertInstanceOf( 'WP_Term', get_term_by( 'id', $id, 'category' ) );
 	}
 
 	public function test_get_object_by_id_gets_an_object() {
 		$id = $this->category_factory->create();
-		$this->assertTrue( (bool) $this->category_factory->get_object_by_id( $id ) );
+		$this->assertInstanceOf( 'WP_Term', $this->category_factory->get_object_by_id( $id ) );
 	}
 
 	public function test_get_object_by_id_gets_an_object_with_the_same_name() {

diff --git a/tests/phpunit/tests/term.php b/tests/phpunit/tests/term.php
@@ -123,7 +123,7 @@ public function test_wp_add_remove_object_terms() {
 		}
 
 		foreach ( $posts as $post_id ) {
-			$this->assertTrue( (bool) wp_delete_post( $post_id ) );
+			$this->assertInstanceOf( 'WP_Post', wp_delete_post( $post_id ) );
 		}
 	}
-Original file line number
+Diff line change
@@ Expand Up / @@ -123,7 +123,7 @@ public function test_wp_add_remove_object_terms() { @@
     		}
     		foreach ( $posts as $post_id ) {
-    			$this->assertTrue( (bool) wp_delete_post( $post_id ) );
+    			$this->assertInstanceOf( 'WP_Post', wp_delete_post( $post_id ) );
     		}
     	}
@@ Expand Down @@