Skip to content
This repository has been archived by the owner on Dec 2, 2020. It is now read-only.

Bug: Cursor is not visible when inserting a new button. #878

Closed
paaljoachim opened this issue Nov 24, 2020 · 5 comments · Fixed by #896
Closed

Bug: Cursor is not visible when inserting a new button. #878

paaljoachim opened this issue Nov 24, 2020 · 5 comments · Fixed by #896
Labels
[Type] Bug Something isn't working

Comments

@paaljoachim
Copy link

paaljoachim commented Nov 24, 2020

NB! Please skip straight to this comment:
#878 (comment)


Describe the bug
Using the Buttons block it looks like this in the backend:
Screen Shot 2020-11-24 at 11 38 14

In comparison with theme Twenty Twenty.

Screen Shot 2020-11-24 at 11 29 22

To Reproduce
Steps to reproduce the behavior:

  1. Add a Buttons block.
  2. Add a few buttons.
  3. Notice the difference between button one and button two.

Expected behavior
All buttons in one nice row.

Editor version (please complete the following information):

  • WordPress version: 5.5.3
  • Gutenberg version: 9.4.1

No other plugin is activated.

Running locally through Desktop Server.
Browser: Chrome
Macbook Pro: OSX 10.15.7

@carolinan
Copy link
Contributor

Related to #859

Do you see the same problem without Gutenberg 9.4.1? Or with 5.6 RC?

@paaljoachim
Copy link
Author

paaljoachim commented Nov 24, 2020

That is interesting!
Turning off the Gutenberg plugin 9.4.1. The buttons show in a nice row as they should.
(No plugins are activated.)

Screen Shot 2020-11-24 at 12 26 58

@carolinan
Copy link
Contributor

carolinan commented Nov 24, 2020

So we need to both work on the open pull request, and narrow down what changed between RC1 and 9.4.1. 🤔

Right so the number of updates between 5.5.3 and 9.4.1 are significant, this also needs to be tested on 5.6 RC.

@paaljoachim
Copy link
Author

paaljoachim commented Nov 24, 2020

NB! A correction!
I downloaded the newest version of Twenty Twenty One. As I had an earlier version installed for the above testing.
I am sorry about that.

Made a new page and added the Buttons block.
No plugin activated.

Twenty-Twenty-One-Buttons-block

I expected a blinking cursor inside when a buttons block is selected.

Activated Gutenberg plugin 9.4.1.

Twenty-Twenty-One-Buttons-Block-With-Gutenberg-plugin

I am thinking either we can look at the missing blinking cursor inside the selected buttons block or we can close the issue.

@carolinan
Copy link
Contributor

carolinan commented Nov 25, 2020

I see the problem, and first I thought it was because the cursor was the same color as the text, which is the background color, but even if I change its color, it does not show up when the button is added, only when you start typing.

@carolinan carolinan changed the title Bug: Buttons block. Adding button 2 creates a shift in height. Bug: Cursor is not visible when inserting a new button. Nov 25, 2020
@carolinan carolinan added the [Type] Bug Something isn't working label Nov 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants