This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
Try: add heading block style to paragraph #366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think styling a paragraph as a heading -even only by the name - is a bad idea because it can give users the idea that headings and paragraphs are interchangeable. We should not make it easier for the user to make mistakes that can cause problems both for SEO and accessibility. I don't have a great alternative at the moment... |
|
I agree, this was just an exploration, but I'm not a fan either |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a paragraph style variation so that the font family values can be altered by theme.json for the style variations to actually work as intended.
Why we use the css property of theme.json for this: WordPress/gutenberg#49550