Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

Block mover not actionable with wide and full alignments #665

Closed
afercia opened this issue Nov 25, 2018 · 1 comment
Closed

Block mover not actionable with wide and full alignments #665

afercia opened this issue Nov 25, 2018 · 1 comment
Labels
bug Something isn't working needs decision

Comments

@afercia
Copy link

afercia commented Nov 25, 2018

I've read the conversation on #614 which recently made a few changes to the block toolbar position. However, I'm not fully convinced a theme should ever try to modify the Gutenberg UI, as this leads to potential breakage.

With those changes, the block mover is not usable when the alignment is set to "wide" of "full".

Normally, the block mover is placed vertically on the left of the block:

screenshot 2018-11-25 at 13 36 35

With a "wide" alignment, it's expected to be placed horizontally and now it's almost completely hidden behind the toolbar:

screenshot 2018-11-25 at 13 36 49

With a "full" alignment, it's completely hidden:

screenshot 2018-11-25 at 13 36 56

It can be used only when the block is not selected and the toolbar doesn't appear, i.e. when the block is in the "hovered" state, which is less than ideal:

screenshot 2018-11-25 at 16 22 48

As mentioned in #614, maybe Gutenberg itself should better handle this cases.

For example, if Twenty Nineteen reverts the change to the toolbar position, that would help for the "Full" alignment:

screenshot 2018-11-25 at 14 59 37

But it wouldn't help for the "wide" alignment because in Twenty Nineteen "wide" is left aligned and there's really no space on the left to display the block movers in their expected horizontal position:

screenshot 2018-11-25 at 16 39 53

Basically this has also to do with the concept of "content width" and the way themes are supposed to alter the wp-block width in the editor (as Twenty Nineteen does).

I'd tend to think this second part should be addressed in Gutenberg, going to create a new issue there.

/Cc @jasmussen

@jasmussen
Copy link
Collaborator

I'll take a look at this one.

jasmussen pushed a commit that referenced this issue Nov 26, 2018
Fixes #665.

This PR reverts the customization to the toolbar for wide and fullwide.

It doesn't look quite as good, but it makes the block mover usable again.

Let's look at some upstream improvements instead, I have a few ideas.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working needs decision
Projects
None yet
Development

No branches or pull requests

3 participants