You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.
I've read the conversation on #614 which recently made a few changes to the block toolbar position. However, I'm not fully convinced a theme should ever try to modify the Gutenberg UI, as this leads to potential breakage.
With those changes, the block mover is not usable when the alignment is set to "wide" of "full".
Normally, the block mover is placed vertically on the left of the block:
With a "wide" alignment, it's expected to be placed horizontally and now it's almost completely hidden behind the toolbar:
With a "full" alignment, it's completely hidden:
It can be used only when the block is not selected and the toolbar doesn't appear, i.e. when the block is in the "hovered" state, which is less than ideal:
As mentioned in #614, maybe Gutenberg itself should better handle this cases.
For example, if Twenty Nineteen reverts the change to the toolbar position, that would help for the "Full" alignment:
But it wouldn't help for the "wide" alignment because in Twenty Nineteen "wide" is left aligned and there's really no space on the left to display the block movers in their expected horizontal position:
Basically this has also to do with the concept of "content width" and the way themes are supposed to alter the wp-block width in the editor (as Twenty Nineteen does).
I'd tend to think this second part should be addressed in Gutenberg, going to create a new issue there.
Fixes#665.
This PR reverts the customization to the toolbar for wide and fullwide.
It doesn't look quite as good, but it makes the block mover usable again.
Let's look at some upstream improvements instead, I have a few ideas.
I've read the conversation on #614 which recently made a few changes to the block toolbar position. However, I'm not fully convinced a theme should ever try to modify the Gutenberg UI, as this leads to potential breakage.
With those changes, the block mover is not usable when the alignment is set to "wide" of "full".
Normally, the block mover is placed vertically on the left of the block:
With a "wide" alignment, it's expected to be placed horizontally and now it's almost completely hidden behind the toolbar:
With a "full" alignment, it's completely hidden:
It can be used only when the block is not selected and the toolbar doesn't appear, i.e. when the block is in the "hovered" state, which is less than ideal:
As mentioned in #614, maybe Gutenberg itself should better handle this cases.
For example, if Twenty Nineteen reverts the change to the toolbar position, that would help for the "Full" alignment:
But it wouldn't help for the "wide" alignment because in Twenty Nineteen "wide" is left aligned and there's really no space on the left to display the block movers in their expected horizontal position:
Basically this has also to do with the concept of "content width" and the way themes are supposed to alter the
wp-block
width in the editor (as Twenty Nineteen does).I'd tend to think this second part should be addressed in Gutenberg, going to create a new issue there.
/Cc @jasmussen
The text was updated successfully, but these errors were encountered: