Twenty Twenty-One Blocks: Add 404 Template #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
commented
Nov 17, 2020
| <!-- wp:template-part {"slug":"header","theme":"twentytwentyone-blocks","align":"full", "tagName":"header","className":"site-header"} /--> | ||
|
|
||
| <!-- wp:heading {"level":1,"align":"wide"} --> | ||
| <h1 class="alignwide">Nothing Here</h1> |
There was a problem hiding this comment.
Once translation is possible in these templates, these strings should be adjusted so they're translatable.
|
Did you set a permalink structure before testing it on the front? 🤔 |
jffng
approved these changes
Nov 18, 2020
|
Good call, I hadn't set permalink settings on this test site yet. 😄 Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #84.
Adds a basic 404 template, as per the designs. Does not style the search block, pending #82.
The PR also fixes the display of wide/full separator blocks in the editor.
I can't get this working in the front end (is that a Gutenberg bug?), but I'm seeing it in the site editor: