Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT1 Blocks Font Weight Value to Headings #239

Merged
merged 4 commits into from
Mar 26, 2021
Merged

Conversation

carolinan
Copy link
Collaborator

Alternative to #135 and #211, using a custom variable for the font weight for the title blocks.

Since WordPress/gutenberg#29941, neither this PR or #211 relies on WordPress/gutenberg#27639

@carolinan
Copy link
Collaborator Author

carolinan commented Mar 24, 2021

I double checked with Twenty Twenty-One:

h1-h3: normal
h4-h6: strong (browser default)

site title: normal

h1.entry-title (single view post/page title): 300

I am not sure why this comment #93 (comment) says H1 should be light?
Not all H1 are also going to be .has-huge-font-size, .has-gigantic-font-size.

Copy link
Collaborator

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working well for me. Thanks!

@kjellr kjellr merged commit 065a468 into master Mar 26, 2021
@kjellr kjellr deleted the tt1-title-block-font-weight branch March 26, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants