-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate CSS for Code block for TT1-block theme #113
Conversation
There is a problem with the text color of the code block, in Twenty Twenty-One, it is being overwritten by the block editor styles. Trac ticket: |
As @carolinan suggested we should be able to add support for custom colors to this block like we have for others. My preference would be to not ship the CSS for borders in the PR but wait for support to be added to Gutenberg. |
b06c63c
to
12c89c3
Compare
Supplied typeography, padding and border style values for code block style defaults
I removed the font size because in the current Twenty Twenty-One the default size of 20px is used. |
Change to support: #94
Reference [TwentyTwentyOne's styles](As expressed by TT1's CODE block styles: https://github.com/WordPress/twentytwentyone/blob/trunk/assets/sass/05-blocks/code/_style.scss) for design target.
Note: There were previously dependencies on changes to Gutenberg to allow some of these changes. The actual changes made were different from the original dependencies but the result was the same.