-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added draft test files #132
Conversation
That looks pretty thorough, as far as the docs are concerned. One thing that I would like to see is consistency with your indentation of the docblocks. There should always be a space before the So like this: /**
* Comment.
*/ Not this: /**
* Comment.
*/ Something that could be added is function/method/hook usage in a file/function/method (see #85). Maybe I'm picky, but in the other file names we use dashes and not underscores, and I think we should be consistent with that. |
Ok, I will modify the files accordingly. Luca
|
I've modified comment indentation, IDE did actually, and renamed the files, ok? |
That looks good to me. |
ok, will look into another issue then On Wed, Oct 1, 2014 at 2:55 PM, J.D. Grimes [email protected]
Luca |
Thank you very much! Pleasure working with you on contributor day! :) |
thanks, it was my pleasure and plan on doing it more frequently On Thu, Oct 2, 2014 at 10:44 AM, Andrey Savchenko [email protected]
Luca |
I've added a draft for test files to be used in place of real source code. Open to input for more/better job to be done.